Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: firefox test #2256

Closed
wants to merge 2 commits into from
Closed

fix: firefox test #2256

wants to merge 2 commits into from

Conversation

wadjih-bencheikh18
Copy link
Member

closes #2255

@wadjih-bencheikh18 wadjih-bencheikh18 linked an issue Mar 22, 2023 that may be closed by this pull request
Firefox test failing #2255
Closed
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 22, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: bee12ad
Status: ✅  Deploy successful!
Preview URL: https://333348f2.nmrium.pages.dev
Branch Preview URL: https://2255-firefox-test-failing.nmrium.pages.dev

View logs

@wadjih-bencheikh18 wadjih-bencheikh18 marked this pull request as draft March 22, 2023 12:10
@wadjih-bencheikh18 wadjih-bencheikh18 force-pushed the 2255-firefox-test-failing branch 2 times, most recently from c196c75 to 50f5f86 Compare March 22, 2023 13:18
@wadjih-bencheikh18
Copy link
Member Author

Click event was being intercepted by a <dialog> element in the center of apply button.I fixed the test by changing click position .I couldn't figure out why there is <dialog> element

@wadjih-bencheikh18 wadjih-bencheikh18 marked this pull request as ready for review March 22, 2023 13:27
@hamed-musallam
Copy link
Member

@wadjih-bencheikh18

the issue happens because the dialog is taking space in the layout which should not if no nodes inside it, this happens because of the display:flex which i think no need for it zakodium-oss/react-science#462

@lpatiny
Copy link
Member

lpatiny commented Mar 23, 2023

This will be solved with dependencies update.

@lpatiny lpatiny closed this Mar 23, 2023
@targos targos deleted the 2255-firefox-test-failing branch March 23, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firefox test failing
4 participants
@wadjih-bencheikh18 @hamed-musallam @lpatiny @targos